Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[QOL] adding a balloon to warn your being devour by a lurker. #6127

Closed
wants to merge 1 commit into from

Conversation

Huffie56
Copy link
Contributor

@Huffie56 Huffie56 commented Apr 9, 2024

About the pull request

doesn't make sense to not be aware of you being devour by a xeno so i made this a sort of fix....

Explain why it's good for the game

Testing Photographs and Procedure

Screenshots & Videos

Put screenshots and videos here with an empty line between the screenshots and the <details> tags.

Changelog

🆑
qol: adding a balloon to warn your being devour by a lurker.
/:cl:

@github-actions github-actions bot added the Quality of Life Make the game harder to play label Apr 9, 2024
@Huffie56 Huffie56 marked this pull request as ready for review April 9, 2024 20:16
@irakligabunia
Copy link
Contributor

don't you think a balloon warning is a bit too much? maybe making the circle of devour action non transparent could work
(lurker is the only one iirc that has the transparent circle)

example: https://files.catbox.moe/oitcc6.png

@Huffie56 Huffie56 marked this pull request as draft April 10, 2024 10:18
@Huffie56 Huffie56 marked this pull request as ready for review April 10, 2024 11:45
@Drulikar Drulikar mentioned this pull request Apr 15, 2024
@Drulikar
Copy link
Contributor

I'm opting to go with a method w/o involving balloon alerts. See above PR

@Drulikar Drulikar closed this Apr 15, 2024
@Huffie56 Huffie56 deleted the balloon_vore branch April 17, 2024 11:45
github-merge-queue bot pushed a commit that referenced this pull request May 1, 2024
# About the pull request

This PR is sort of a different implementation of #6127 opting against
balloon alerts for devour that does several things:
- Lurker invis recharge is now 20s base (up from 15s)
- Lurker invis can now be toggled giving you 90% of the time you didn't
use (and with 0.5s of double click prevention like I previously gave to
all /datum/action/xeno_action/activable )
- Bumping still ends invisibility but refunds 50% of the time you didn't
use
- Devouring now ends invisibility but refunds 50% of the time you didn't
use
- Removed balloon alerts for defender crest toggling
- Code refactor to actually utilize xeno ability cooldowns means that
CDR can affect the ability now, but xenos have very little access to CDR
- Changes the invisibility time remaining status message to also mention
invisibility recharge time.

# Explain why it's good for the game
Gives lurkers more flexibility to have their ability ready when they may
need it, resolves the issue of lurkers trying to sneak a devour, and
makes bumping slightly less punishing.

The increase in the recharge time is intended to make an ambush more
calculated offering marines a little more time to retaliate before the
lurker may vanish again.

# Testing Photographs and Procedure
<details>
<summary>Screenshots & Videos</summary>

https://youtu.be/ODEF7E6lDrI

</details>


# Changelog
:cl: Drathek
balance: Lurker invisibility recharge time is now 20s (up from 15s)
balance: Lurker invisibility now ends when devouring but refunds 50% of
time unused
balance: Lurker invisibility bump now refunds 50% of time unused
balance: Lurker invisibility can now be toggled refunding 90% of time
unused (with dbl click prevention)
del: Removed defender crest toggle balloon alerts
fix: Lurker invisibility code is refactored to properly use cooldowns
and now doesn't incorrectly get interrupted by bump code
add: Lurker invisibility recharge time is now displayed in status tab
/:cl:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Quality of Life Make the game harder to play
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants